Thumbs up/down

[Chris2k]

Can any1 tell me whats wrong here:

    $thumbsUp = $_POST['good'];
    $thumbsDown = $_POST['bad'];
    
    $id = isset($_GET['id']) ? mysql_real_escape_string(trim($_GET['id'])): '';
    
    if ($thumbsUp) {
        mysql_query("UPDATE wcddl_downloads SET thumbsup=thumbsup+1 WHERE id='$id'");
    } 

Basically when i press the thumbsu button i want to increment the field +1 for tht ddl.

Chris2k Reviewed by Chris2k on 9th Oct 2011. Thumbs up/down Can any1 tell me whats wrong here: $thumbsUp = $_POST; $thumbsDown = $_POST; $id = isset($_GET) ? mysql_real_escape_string(trim($_GET)): ''; if ($thumbsUp) { mysql_query("UPDATE wcddl_downloads SET thumbsup=thumbsup+1 WHERE id='$id'"); Rating: 5

[Putin]

$thumbsUp = isset($_POST['good']) ? true : false;
$thumbsDown = isset($_POST['bad']) ? true : false;

$id = isset($_GET['id']) ? (int)$_GET['id'] : 0;

if ($thumbsUp) {
mysql_query("UPDATE `wcddl_downloads` SET `thumbsup`=thumbsup+1 WHERE `id`=".$id."");
}

I've changed a few things to clean the script up to make it work better. But it wont solve the problem...

the SQL query you've entered it FINE, maybe you've mis-spelt something in the query or the POST isn't POSTing...

Edit: I also noticed...GET for id, and POST for good/bad, maybe they are both GET or POST? ..

[Gaurav]

@MP3Drug: isset() returns boolean TRUE or FALSE so using a ternary operator won't do anything better..

[Mr Happy]

Warning that your not recording anyone's IP address for particular submit ID. I'd have another table that contains the IP address and id. When they vote as well as recording if it's a vote up or down like your doing I'd make it record the IP and submit id in the new table. Whenever someone tries to vote first check if the IP has already voted for that id. If not then let them vote. If they have return a message saying they've already voted.

The way it is currently anyone can vote a hundred times for the same submit.

[soft2050]

I see no syntax error in your php code and i guess it would be right

I guess there could be problem in mysql query:

mysql_query("UPDATE wcddl_downloads SET thumbsup=thumbsup+1 WHERE id='$id'"); 

Add die with mysql query:

mysql_query("UPDATE wcddl_downloads SET thumbsup=thumbsup+1 WHERE id='$id'") or die(mysql_error()); 

This will let you know if there's problem in the query

The other problem i am guessing is the 'good' data is not posted

Try seeing if its posted

$thumbsUp = $_POST['good']; 
    $thumbsDown = $_POST['bad']; 
     
    $id = isset($_GET['id']) ? mysql_real_escape_string(trim($_GET['id'])): ''; 
     
    if ($thumbsUp) { 
        mysql_query("UPDATE wcddl_downloads SET thumbsup=thumbsup+1 WHERE id='$id'"); 
    } else {
  die('Shit Happened and you didn't posted anything');
} 

I guess it would be the above error

Edit: Just replace this too if the above doesn't works:

$id = (isset($_GET['id'])) ? mysql_real_escape_string(trim($_GET['id'])): ''; 

[Chris2k]

i tried ur code soft2050 in my leftbar.php, this what im getting even i didnt press buttton



EDIT: better thinking, im gonna add my php code to funcs.php

[soft2050]

i tried ur code soft2050 in my leftbar.php, this what im getting even i didnt press buttton

Hmm! Yeah! Just ignore that for now! You can try it for testing and remove afterwards
Try to press Good Download now
And see if it still shows that thing or something else

[Chris2k]

tested, no luck.


EDIT: better thinking, im gonna add my php code to funcs.php

[soft2050]

tested, no luck.


EDIT: better thinking, im gonna add my php code to funcs.php

Adding it to funcs.php wont help

Paste the output of the html (page source) here
There's some problem in posting data

[Chris2k]

here is my form,

	<form action="" method="post">
	
        <input name="good" type="button" value="Good Download xD" /> <input name="bad" type="button" value="Bad Download :)" />
    </form>

here's a test http://warezrelease.info/download-11...UR%29-PS3.html