Thumbs up/down

[Chris2k]

ok so now im adding an IP check, here's what ive come up with:

    $IP = gethostbyname($_SERVER['REMOTE_ADDR']);
    $id = (isset($_GET['id'])) ? mysql_real_escape_string(trim($_GET['id'])): ''; 
    
     $check = "SELECT ip FROM wcddl_downloads WHERE id = '$id'";
    $result = mysql_query($check) or die(mysql_error());
    
    if ($IP == $result) {
        $thumbsHTML .= 'You have already voted';
    } else {
        $thumbsHTML .= '
        <center>
        <form action="" method="post">
        
            <input name="good" type="submit" value="." id="upBtn" /><br />
            <input name="bad" type="submit" value="." id="downBtn" />
        
        </form>
        </center>';
    } 

doesnt seem to work, why? any help.

Chris2k Reviewed by Chris2k on 12th Oct 2011. Thumbs up/down Can any1 tell me whats wrong here: $thumbsUp = $_POST; $thumbsDown = $_POST; $id = isset($_GET) ? mysql_real_escape_string(trim($_GET)): ''; if ($thumbsUp) { mysql_query("UPDATE wcddl_downloads SET thumbsup=thumbsup+1 WHERE id='$id'"); Rating: 5

[soft2050]

ok so now im adding an IP check, here's what ive come up with:

    $IP = gethostbyname($_SERVER['REMOTE_ADDR']);
    $id = (isset($_GET['id'])) ? mysql_real_escape_string(trim($_GET['id'])): ''; 
    
     $check = "SELECT ip FROM wcddl_downloads WHERE id = '$id'";
    $result = mysql_query($check) or die(mysql_error());
    
    if ($IP == $result) {
        $thumbsHTML .= 'You have already voted';
    } else {
        $thumbsHTML .= '
        <center>
        <form action="" method="post">
        
            <input name="good" type="submit" value="." id="upBtn" /><br />
            <input name="bad" type="submit" value="." id="downBtn" />
        
        </form>
        </center>';
    } 

doesnt seem to work, why? any help.

I see no point why you should use gethostbyname after getting user ip
And you are checking the ip with the mysql query results
$IP == $result

Use mysql_num_rows to count results! Try this:

    $IP = $_SERVER['REMOTE_ADDR'];
    $id = (isset($_GET['id'])) ? mysql_real_escape_string(trim($_GET['id'])): ''; 
    
    $check = "SELECT ip FROM wcddl_downloads WHERE id = '$id'";
    $result = mysql_query($check) or die(mysql_error());
    
    if (mysql_num_rows($result)==0) {
        $thumbsHTML .= '
        <center>
        <form action="" method="post">
        
            <input name="good" type="submit" value="." id="upBtn" /><br />
            <input name="bad" type="submit" value="." id="downBtn" />
        
        </form>
        </center>';
    } else {
       $thumbsHTML .= 'You have already voted';
    }