Thumbs up/down

[Kw3rLn]

Your buttons doesnt work, are you trying to make them work? What functions they have? I didnt work with DDL scripts before.

[soft2050]

here is my form,

    <form action="" method="post">
    
        <input name="good" type="button" value="Good Download xD" /> <input name="bad" type="button" value="Bad Download :)" />
    </form>

here's a test http://warezrelease.info/download-11...UR%29-PS3.html

Wheres the submit button?
Add it somewhere and it will be fine

[Chris2k]

ty m8, it works.

obvios fix lol, any suggestions to recoord IP?

[soft2050]

ty m8, it works.

obvios fix lol, any suggestions to recoord IP?

Use $_SERVER['REMOTE_ADDR'] for getting user ip
Add it in a table and search for the ip in the database! Add only if it doesn't existAlso, it would be better if you use RadioButtons

[Putin]

@MP3Drug: isset() returns boolean TRUE or FALSE so using a ternary operator won't do anything better..

Yes as I said.. "I've changed a few things to clean the script up to make it work better. But it wont solve the problem..."

:-)

He uses isset() on other parts of the script but not the parts where it's actually needed to be a 100% error free snippet of script.

Also that $id = isset($_GET['id']) ? mysql_real_escape_string(trim($_GET['id'])): '';
it rather pointless... only a (int) is required as mysql_real_escape_string() makes an unnecassary database query.

[Putin]

Actually, using the IP is no longer a thing which webmasters should use in my own personal opinion. Many people have dynamic IP addresses - some even have a new IP every page load.

I'd use a md5 hash to be sent which blocks multiple inserts and also if they manage to unset the session of there end... the md5 can confirm it's the same or similar browser - in the md5 I'd have user agent and other header information (more header information the better, makes them more unique + a day / month via date()).

^ and that would mean you'd be XSS protected.

[Chris2k]

ok so now im adding an IP check, here's what ive come up with:

    $IP = gethostbyname($_SERVER['REMOTE_ADDR']);
    $id = (isset($_GET['id'])) ? mysql_real_escape_string(trim($_GET['id'])): ''; 
    
     $check = "SELECT ip FROM wcddl_downloads WHERE id = '$id'";
    $result = mysql_query($check) or die(mysql_error());
    
    if ($IP == $result) {
        $thumbsHTML .= 'You have already voted';
    } else {
        $thumbsHTML .= '
        <center>
        <form action="" method="post">
        
            <input name="good" type="submit" value="." id="upBtn" /><br />
            <input name="bad" type="submit" value="." id="downBtn" />
        
        </form>
        </center>';
    } 

doesnt seem to work, why? any help.

[soft2050]

ok so now im adding an IP check, here's what ive come up with:

    $IP = gethostbyname($_SERVER['REMOTE_ADDR']);
    $id = (isset($_GET['id'])) ? mysql_real_escape_string(trim($_GET['id'])): ''; 
    
     $check = "SELECT ip FROM wcddl_downloads WHERE id = '$id'";
    $result = mysql_query($check) or die(mysql_error());
    
    if ($IP == $result) {
        $thumbsHTML .= 'You have already voted';
    } else {
        $thumbsHTML .= '
        <center>
        <form action="" method="post">
        
            <input name="good" type="submit" value="." id="upBtn" /><br />
            <input name="bad" type="submit" value="." id="downBtn" />
        
        </form>
        </center>';
    } 

doesnt seem to work, why? any help.

I see no point why you should use gethostbyname after getting user ip
And you are checking the ip with the mysql query results
$IP == $result

Use mysql_num_rows to count results! Try this:

    $IP = $_SERVER['REMOTE_ADDR'];
    $id = (isset($_GET['id'])) ? mysql_real_escape_string(trim($_GET['id'])): ''; 
    
    $check = "SELECT ip FROM wcddl_downloads WHERE id = '$id'";
    $result = mysql_query($check) or die(mysql_error());
    
    if (mysql_num_rows($result)==0) {
        $thumbsHTML .= '
        <center>
        <form action="" method="post">
        
            <input name="good" type="submit" value="." id="upBtn" /><br />
            <input name="bad" type="submit" value="." id="downBtn" />
        
        </form>
        </center>';
    } else {
       $thumbsHTML .= 'You have already voted';
    }