DDLCMS v2.0 Pre-Release

**JmZ** · 28th Oct 2009, 04:34 PM

There are parts of the code which are very inefficient but for the audience who it is aimed at, they aren't much of a problem.

Its when a site with 30k+ a day tries using it that it'll start showing.

Like I said though, the audience using it won't really be affected so good job I guess.

Seems most vulns were fixed too.

**litewarez** · 28th Oct 2009, 04:51 PM

Well for starters theres the way the PHP code blocks are mixed with the html source..
Theres the way the directories are Layed out
Theres the htaccess file, Lolz dont get me started but thats soo much of a mess its beyond be lol
theres the way he checking for admin security, even tho it work's the same as it should, its just incorrect usage of php, you should atleast start using objects/methods and organize the code.

For examples here is MY Index file

PHP Code:


<?php

//File Defines
include 'xxxxxxxx.php';
//Initiate startup by calling the startup file!
include _ROOT.'xx/xx/xx/startup_frontend.'._EXT;

$smarty = $registry->get('smarty');
if(!$smarty->is_cached('frontend/index.tpl')){
    include_function_file('functions_page');
    page_name('Home');

    $litewarez = $registry->get('litewarez');
    $smarty->assign('types',$litewarez->getTypes());
    $smarty->assign('downloads',$litewarez->getDownloads());
    include_class_file('pagination');
    $page_data = $litewarez->getPaginationData();
    $p = new pagination();
    $p->Items($page_data['total_rows']);
    $p->limit($page_data['per_page']);
    $p->currentPage($page_data['current']);
    $p->urlFriendly('%s');
    $p->target($registry->get('input')->createSprintfPageLinks());
    $smarty->assign('pagination_data',$p->getOutput());
    $smarty->assign('page_load_time',number_format((microtime(true)-FIRST_LOAD_TIME),4,'.',''));
    $smarty->assign('sql_queries',$registry->get('database')->query_counter);
    $smarty->assign('users_online',$registry->get('user_tracker')->countOnline());
    $smarty->assign('tag_cloud_array',$registry->get('tagcloud')->GetTags());
    $smarty->assign('latest_10_downloads',$registry->get('litewarez')->getLatestDownloads(10));
}
    $smarty->display('index.template',$_REQUEST);
?>

And as you can see from my example that all my code in the index.php IS OBJECT BASED.

PHP Code:



<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
    "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
    <head>
        <meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />
        <meta http-equiv="Content-Language" content="en-us" />
<?php
    # Kill any security threats:
    include(WWWROOT . 'killthreat.php');
    # clean up search query here:
    if(!isset($threat) && isset($_POST) && is_array($_POST) && count($_POST) > 0 && checkPostForm('mainSearch', $_POST) === TRUE && $spamSearch !== TRUE)
    {
        $q = $_POST['q'];
        $type = $_POST['type'];
    }
    elseif(!isset($threat) && isset($_POST) && is_array($_POST) && count($_POST) > 0 && checkPostForm('sideSearch', $_POST) === TRUE && $spamSearch !== TRUE)
    {
        $q = $_POST['q'];
    }
    elseif(!isset($threat) && isset($_GET) && is_array($_GET) && count($_GET) > 0 && checkURLQuery('index.php_pageFilter', $_GET) === TRUE && $spamSearch !== TRUE)
    {
        $filterURL = $_GET['filterURL'];
        $page = $_GET['page'];
    }
    elseif(!isset($threat) && isset($_GET) && is_array($_GET) && count($_GET) > 0 && checkURLQuery('index.php_searchResults', $_GET) === TRUE && $spamSearch !== TRUE)
    {
        $q = $_GET['q'];
    }
    elseif(!isset($threat) && isset($_GET) && is_array($_GET) && count($_GET) > 0 && checkURLQuery('index.php', $_GET) === TRUE && $spamSearch !== TRUE)
    {
        $type = $_GET['type'];
    }
    else
    {
        unset($q);
        unset($type);
    }
    require(WWWROOT . 'main.php');
    $ddl = new ddl();
    $ddl->open();
    if(isset($q))
    {
        $ddl->get($q, $types);
    }
    else
    {
        $ddl->get('', $types);
    }
    if(isset($q) && $spamSearch !== TRUE)
    {
        $keywords_list = str_replace(',', ' ' . $q . ', ', $keywords) . ' ' . $q;
?>
        <title><?php echo capitalize($q); ?> @ <?php echo $site_name; ?> - Download <?php echo $q; ?> here.</title>
        <meta name="description" content="Download <?php echo $q; ?> here. <?php echo $description; ?>" />
        <meta name="keywords" content="<?php echo $keywords_list; ?>" />
<?php
    }
    elseif(isset($type))
    {
?>
        <title><?php echo $type; ?> Downloads @ <?php echo $site_name; ?> : <?php echo $description; ?></title>
        <meta name="description" content="<?php echo $description; ?>" />
        <meta name="keywords" content="<?php echo $keywords; ?>" />
<?php
    }
    elseif(isset($toptype))
    {
?>
        <title>Top <?php echo $topdownloads; ?> <?php echo $toptype; ?> Downloads @ <?php echo $site_name; ?>: <?php echo $description; ?></title>
        <meta name="description" content="<?php echo $description; ?>" />
        <meta name="keywords" content="<?php echo $keywords; ?>" />
<?php
    }
    elseif(isset($newspage))
    {
?>
        <title><?php echo str_replace('.' , ' ' , $title); ?> @ <?php echo $site_name; ?></title>
        <meta name="description" content="Download <?php echo $title; ?>" />
        <meta name="keywords" content="<?php echo $title; ?> <?php echo $keywords; ?>" />
<?php
    }
    else
    {
?>
        <title><?php echo $site_name; ?>: <?php echo $description; ?></title>
        <meta name="description" content="<?php echo $description; ?>" />
        <meta name="keywords" content="<?php echo $keywords; ?>" />
<?php
    }
?>
        <link rel="stylesheet" href="<?php echo $site_url; ?>/skins/<?php echo $skin; ?>/stylesheet.css" type="text/css" />
        <link rel="icon" href="favicon.ico" />
        <link rel="shortcut icon" href="favicon.ico" />
        <script type="text/javascript" src="<?php echo $site_url; ?>/ddlcms.js"></script>
    </head>
    <body>
        <center>
            <table border="0" cellpadding="0" cellspacing="0" width="1080" class="middle">
                <tbody>
                    <tr class="top">
                        <td colspan="2" style="padding-left: 135px;">
                            <table border="0" cellpadding="0" cellspacing="0">
                                <tr>
                                    <td width="315">
                                        <form action="<?php echo $site_url; ?>/index.php" method="post" style="margin: 0; padding: 0;">
<?php
    if(isset($q))
    {
?>
                                            <img src="<?php echo $site_url; ?>/skins/<?php echo $skin; ?>/magnifying_glass.png" height="38" width="38" alt="<?php echo $q; ?> Search @ <?php echo $site_name; ?>" align="middle" />
<?php
    }
    else
    {
?>
                                            <img src="<?php echo $site_url; ?>/skins/<?php echo $skin; ?>/magnifying_glass.png" height="38" width="38" alt="Search @ <?php echo $site_name; ?>" align="middle" />
<?php
    }
?>
                                            <select name="type" class="formselect">
                                                <option selected="selected" value="">All</option>
<?php
    $ddl->option_list();
?>
                                            </select>
<?php
    if(isset($q))
    {
?>
                                            <input type="text" name="q" value="<?php echo $q; ?>" class="formtop" maxlength="60" title="<?php echo $q; ?> Search @ <?php echo $site_name; ?>" />
                                            <input type="image" src="<?php echo $site_url; ?>/skins/<?php echo $skin; ?>/go.png" alt="<?php echo $q; ?> Search @ <?php echo $site_name; ?>" align="middle" />
<?php
    }
    else
    {
?>
                                            <input type="text" name="q" value="" class="formtop" maxlength="60" title="Search @ <?php echo $site_name; ?>" />
                                            <input type="image" src="<?php echo $site_url; ?>/skins/<?php echo $skin; ?>/go.png" alt="Search @ <?php echo $site_name; ?>" align="middle" />
<?php
    }
?>
                                        </form>
                                    </td>
                                    <td>
<?php
    include(WWWROOT . 'bookmark_small.php');
?>
                                    </td>
                                </tr>
                            </table>
                        </td>
                    </tr>
                    <tr>
                        <td height="170" width="1010" colspan="2" class="headerboard">
                            <table class="max" border="0" cellpadding="0" cellspacing="0">
                                <tr valign="middle" class="amax">
                                    <td align="left">
                                        <h1><a href="<?php echo $site_url; ?>" target="_top" title="<?php echo $site_name; ?>: <?php echo $description; ?>" class="h1"><?php echo $site_name; ?></a></h1>
                                        <span class="header_description"><?php echo $description; ?></span>
                                    </td>
                                </tr>
                                <tr valign="bottom" class="half">
<?php
    # Firefox fix for menu buttons padding
    if(strpos($_SERVER['HTTP_USER_AGENT'], 'Firefox'))
    {
        $bottompadding = 0;
    }
    else
    {
        $bottompadding = 10;
    }
?>

                                    <td align="<?php echo $menualign; ?>" style="padding-bottom: <?php echo $bottompadding; ?>px;">
                                        <table border="0" cellpadding="0" cellspacing="3">
                                        <tr>

                                        <td align="center" class="topmenu"><a target="_self" href="<?php echo $site_url; ?>/" class="topmenulink" title="All Files">All Files</a></td>

<?php
    for($i = 0; $i < count($categories); $i++)
    {
        if($categories[$i] == 'Xxx')
        {
?>
                                        <td align="center" class="topmenu"><a target="_self" href="<?php echo $site_url; ?>/porno-<?php echo $categories[$i]; ?>.htm" class="topmenulink" title="<?php echo $categories[$i]; ?> Downloads"><?php echo $categories[$i]; ?></a></td>
<?php
        }
        else
        {
?>
                                        <td align="center" class="topmenu"><a target="_self" href="<?php echo $site_url; ?>/type-<?php echo $categories[$i]; ?>.htm" class="topmenulink" title="<?php echo $categories[$i]; ?> Downloads"><?php echo $categories[$i]; ?></a></td>
<?php
        }
    }
?>

                                        </tr>
                                        </table>
                                    </td>
                                </tr>
                            </table>
                        </td>
                    </tr>
                    <tr class="boxtop_dualpane"><td colspan="2"></td></tr>
                    <tr class="boxmiddle_dualpane"><td colspan="2" align="center">
                        <table border="0" width="100%" cellpadding="10">
                            <tr>
<?php
    if(isset($threat) && !isset($q))
    {
?>
                                <b>Those tags are not allowed in the search.</b>
<?php
    }
?>

No what im saying is the is just poor programming but as JmZ says, it wont affect the targeted market

**Little Dragon** · 28th Oct 2009, 06:41 PM

Thanks JmZ, I appreciate your honesty (I always knew you were a good guy

)

@ Litewarez, yes you are right, it's not object based for the most part -- but not "without a care" though -- there is a reason.

Like you said yourself "for the target market" -- not newbies (I am not a newb

) but for non-programmers, so the script can be handled and edited by most webmasters who are not professional coders.

Now a coder's opinion would be that since it's not object oriented, that it's "poor programming" because looking at the code, it's all on one page, but this script doesn't work any less efficient than if it were object oriented -- and mainly, this script was made specifically for scene webmasters.

**litewarez** · 28th Oct 2009, 06:47 PM

This script was not made for scene webmasters as you have promoted it on hotscripts

and tbh dood, im sure my code would be more user friendly then yours as i can do summat like

PHP Code:


$my_downloads = $litewarez->load('Downloads.Table',$litewarez->getDownloads());

/*
$my_downloads = {
    <table>DownloadData</table>
}
*/

Now im sure if you can handle and understand using objects you would of used a method where all your developed code may be complex but it would be in the background and the user code such as the sample above would be available for the end-user to change is they wish

And as for the JmZ comment read it again carefully, not everyone loves you haha

Also: You promote your script as the most power full ddl system in the scene and it really is not that powerfull. its has a lot of features yes but im sure in the long run webmasters would prefer stability of looks and features...

**DEViANCE** · 28th Oct 2009, 06:55 PM

Not bad, though i am not keen on the way the links are now made or all of the mods/additions, i think it should be replaced with - not . but i made this like that on my siote long ago and can modify the new script to do it how i like.

I like the site download rating, but the vip thing is useless to me really, i let whitelisted sites downloads through auto anyway.

I will upgrade www.evilddl.com soon but will wait till i have a bit more spare time as i have modded my site quite a lot and it will take a bit more than just following the upgrade instructions to get it back to how i want it.

I also agree the code needs a LOT of cleaning up and optimizing but still the script is perfect for what i need, thanks again

PS: you forgot to mentiuon it now gzips pages, been doing this on my site since day one.

**Little Dragon** · 28th Oct 2009, 07:02 PM

@litewarez:

The script IS made for scene webmasters -- what difference does it make if it's on hotscripts? Who else would use a ddl script?

I understand what object based programming is, thanks, but you don't need to elaborate.

As for JmZ comment I appreciated that it was honest, even though was with some criticizm but no sarcasm. I appreciate that.

"not everyone loves you haha" what's your point here? I thanked you for your criticizm too, I don't really care to argue with you and ramble back and forth about the same crap.

Really, can we stay on topic and not hijack this thread, which is really about the pre-release of DDLCMS v2.0.

**frontlinegamerz** · 28th Oct 2009, 07:34 PM

offtopic i submitted to rapidshareddl.com but pulled the link back after noticing that it wasn't updated very much as far as accepting the que. that could be a good traffic site for sites if it was updated daily

**Little Dragon** · 28th Oct 2009, 07:37 PM

It was waiting for DDLCMS v2.0, so it'll be updated regularly now!

**ddlshack** · 28th Oct 2009, 10:23 PM

Hmm, I thought you used a template engine?

**litewarez** · 28th Oct 2009, 10:34 PM

i dont argue alot and ive bit my lip to hold my criticism down, just from a long time warez member and a professional programmer i hate to see all these webmasters using such a poor system.... needs to be inproved a hell of a lot

DDLCMS v2.0 Pre-Release

Thread Tools

Display

Sponsored Links

Thread Information

Users Browsing this Thread

Similar Threads

ddlcms

help with ddlcms!

DDLCMS help please...

Need help in ddlcms

Tags for this Thread

Posting Permissions

themaCreator - create posts from...

themaPoster - post to forums and...

themaManager - edit and manage...

themaLeecher - leech and manage...

themaRegister - register to forums...